Skip to content

NI-RFSG metadata from codegenerated files with some cleanup and dev status override logic#2124

Merged
ni-jfitzger merged 3 commits intoni:masterfrom
vnktshr21:rfsgmetadatacodegenfilesfinal
Aug 4, 2025
Merged

NI-RFSG metadata from codegenerated files with some cleanup and dev status override logic#2124
ni-jfitzger merged 3 commits intoni:masterfrom
vnktshr21:rfsgmetadatacodegenfilesfinal

Conversation

@vnktshr21
Copy link
Collaborator

@vnktshr21 vnktshr21 commented Aug 1, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Updated the get_development_status codegen helper logic to allow a override of development status via config_addon(this will be used for setting development status for RFSG release, which does not align with existing version based logic)
  • Adding rfsg metadata files out of internal codegeneration tool
    • Corrected couple of enum names
    • Documentation corrections
    • functions.py and attributes.py will contain re-arranged entries, but the generated API being unchanged should validate that its just re-arranged
    • Few default value fields got removed
    • Repcap related fields for functions got added by the codegen tool
  • Cleaned up get_deembedding_sparameters method to correctly have only one return value (matches .NET API)
    • Needed to add fancy function to get this working correctly
  • Corrected session locking for write_arb_waveform methods

What testing has been done?

  • System tests pass with simulated and real hardware
  • API codegen shows only expected updates as diff
  • Verified the development_status override logic to be working fine, if we provide a override value

@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 86.66667% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.08%. Comparing base (6ca1890) to head (c41cb70).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
generated/nirfsg/nirfsg/session.py 85.71% 4 Missing ⚠️
build/helper/helper.py 90.00% 1 Missing ⚠️
generated/nirfsg/nirfsg/_library_interpreter.py 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2124      +/-   ##
==========================================
- Coverage   89.09%   89.08%   -0.01%     
==========================================
  Files          71       71              
  Lines       18946    18960      +14     
==========================================
+ Hits        16879    16890      +11     
- Misses       2067     2070       +3
Flag Coverage Δ
codegenunittests 84.44% <90.00%> (-0.05%) ⬇️
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 85.52% <ø> (ø)
nifgensystemtests 94.61% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 75.78% <85.71%> (-0.01%) ⬇️
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
generated/nirfsg/nirfsg/_library.py 69.54% <100.00%> (ø)
build/helper/helper.py 78.84% <90.00%> (-1.16%) ⬇️
generated/nirfsg/nirfsg/_library_interpreter.py 65.21% <80.00%> (ø)
generated/nirfsg/nirfsg/session.py 89.23% <85.71%> (-0.19%) ⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca1890...c41cb70. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

ni-jfitzger
ni-jfitzger reviewed Aug 2, 2025
View reviewed changes
Copy link
Collaborator

@ni-jfitzger ni-jfitzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not hurting anything, but the final return statement in write_arb_waveform is unreachable.

ni-jfitzger
ni-jfitzger reviewed Aug 2, 2025
View reviewed changes
@ni-jfitzger
Copy link
Collaborator

ni-jfitzger commented Aug 2, 2025

I didn't look too closely at the function metadata changes or the documentation changes, but I reviewed the rest and it looks okay to me.

@vnktshr21 vnktshr21 changed the title Rfsg metadata from codegenerated files with some cleanup and dev status override logic NI-RFSG metadata from codegenerated files with some cleanup and dev status override logic Aug 4, 2025
@ni-jfitzger ni-jfitzger merged commit 104f48a into ni:master Aug 4, 2025
39 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ni-jfitzger ni-jfitzger ni-jfitzger approved these changes

@marcoskirsch marcoskirsch Awaiting requested review from marcoskirsch marcoskirsch is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vnktshr21 @codecov-commenter @ni-jfitzger